Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial UI refresh for the grafana integration #182

Closed
a2batic opened this issue Jul 19, 2017 · 7 comments
Closed

Initial UI refresh for the grafana integration #182

a2batic opened this issue Jul 19, 2017 · 7 comments

Comments

@a2batic
Copy link
Member

a2batic commented Jul 19, 2017

Cluster specific objects like volumes and pools are to be removed from the main navigation bar. These views would only be available under a specific cluster. Update the navigation to allow quick switching between different clusters.

@brainfunked
Copy link
Contributor

brainfunked commented Jul 25, 2017

The following navigation entries would be available post the refresh from the ui-legacy-code branch, which was created as part of the codebase refresh addressed in Tendrl/ui#486.

  • Remove the global navigation items for cluster specific objects such as volumes, pools, bricks etc.
  • Retain the global navigation entries for Clusters, Hosts, Admin.
  • Retain the global navigation entry for Alerts.
  • Retain the top navigation entry for the notifications panel and authentication.

@brainfunked brainfunked changed the title Remove cluster specific objects from the main navigation bar Retained UI functionality from pre-grafana UI implementation Jul 25, 2017
@brainfunked
Copy link
Contributor

The following functionality would be carried forward from the ui-legacy-code branch, which was created as part of the codebase refresh addressed in Tendrl/ui#486.

  • Notifications drawer
  • Global alerts list
  • Hosts list
  • Tasks list
  • Task details page
  • Authentication

Other functionality such as workflows, list views and the various object details views would be ported subsequently. The updated cluster list views are being addressed in spec #181, while the import flow would be ported in spec #183.

@brainfunked brainfunked changed the title Retained UI functionality from pre-grafana UI implementation Initial UI refresh for the grafana integration Jul 25, 2017
a2batic pushed a commit to a2batic/specifications that referenced this issue Jul 25, 2017
a2batic pushed a commit to a2batic/specifications that referenced this issue Jul 25, 2017
@ltrilety
Copy link

ltrilety commented Aug 7, 2017

I have several doubts about this issue. As the issue doesn't correspond to what was said in #200

Especially these two points makes me wonder:

  • Remove the global navigation items for cluster specific objects such as volumes, pools, bricks etc.
  • Retain the global navigation entries for Clusters, Hosts, Admin.

As I see it:
  • Via Design A there should be Clusters, Users, Mail Settings and SNMP Settings navigation items plus upper menu with notifications no Hosts no Admin etc.
  • Via Design B there should be no just context selector and upper menu for users, snmp plus smtp settings, and alerts once again no Hosts etc.
  • Via mockups provided by @gnehapk there should be all navigation items including volumes, bricks etc.

So my question is what design is followed, if any?
Especially when I don't see any response on Ju comment #200 (comment) which is already two weeks old.

@a2batic
Copy link
Member Author

a2batic commented Aug 8, 2017

@ltrilety, This setup is for Initial milestone, the specification and setup will be updated as soon as designs get finalized and we move towards other milestones.

@ltrilety
Copy link

ltrilety commented Aug 8, 2017

@a2batic thanks for answer, it's just I don't understand what this particular changes improve in the long term point of view. If it should be the raw base from which a new UI will be created, I don't know why there is still Hosts list and Tasks list present. Anyway more logical to me seems to finish first the design or more precisely decide which one to follow. However it's your call.

@julienlim
Copy link
Member

@ltrilety - we are recommending going with Design B, and we're waiting on @sankarshanmukhopadhyay and Team to advise which Milestone it will land in.

@nthomas-redhat
Copy link
Contributor

Closing this issue as the PRs associated with this issue are merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants