Added parameter TendrlContext.cluster_name for the flow
#73
Conversation
tendrl-bug-id: Tendrl/node-agent#602 Signed-off-by: Shubhendu <shtripat@redhat.com>
|
@Tendrl/tendrl-core @rishubhjain @r0h4n plz review This is required for Tendrl/commons#720 |
|
@shtripat Can you add self.cluster_name to https://github.com/Tendrl/monitoring-integration/blob/master/tendrl/monitoring_integration/objects/trigger/__init__.py#L6 Also I think I missed self.integration_id I am not sure, but I feel the object class must have all the attributes in the constructor |
| @@ -18,6 +18,7 @@ namespace.monitoring: | |||
| inputs: | |||
| mandatory: | |||
| - TendrlContext.integration_id | |||
| - TendrlContext.cluster_name | |||
There was a problem hiding this comment.
Add the new input parameter here too https://github.com/Tendrl/commons/blob/master/tendrl/commons/utils/monitoring_utils.py#L9
There was a problem hiding this comment.
Ah yes while testing I had it here. Forgot to post in PR somehow. Will update the PR
There was a problem hiding this comment.
Added as part of Tendrl/commons#720
Is its really used down the line. If required we can add |
tendrl-bug-id: Tendrl/node-agent#602
Signed-off-by: Shubhendu shtripat@redhat.com