Modifying alerting logic based on alert classifications #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tendrl-bugid: Tendrl#218 Signed-off-by: GowthamShanmugam <gshanmug@redhat.com>
rishubhjain
reviewed
Oct 26, 2017
| response = [b'<h1>Alert Received</h1>'] | ||
| response = Response('Alert received successfully') | ||
| response.headers['content-length'] = len(response.data) | ||
| response.status_code = 200 | ||
| except (IOError, AssertionError) as ex: |
There was a problem hiding this comment.
is AssertionError required?
There was a problem hiding this comment.
yes it required
rishubhjain
reviewed
Oct 26, 2017
| data = env['wsgi.input'].read() | ||
| data = env['wsgi.input'].read( | ||
| int(env['CONTENT_LENGTH']) | ||
| ) | ||
| data = json.loads(data) | ||
| self.alert_handler.handle_alert( | ||
| data["ruleId"] |
There was a problem hiding this comment.
Can we put a check for ruleId (For edge cases), or the ruleId will be there no matter what?
There was a problem hiding this comment.
ok i will do it
|
@shtripat @r0h4n @nnDarshan @rishubhjain please review |
tendrl-bugid: Tendrl#218 tendrl-bugid: Tendrl#216 Signed-off-by: GowthamShanmugam <gshanmug@redhat.com>
|
@r0h4n verified |
r0h4n
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tendrl-bugid: #218
tendrl-bugid: #216
Signed-off-by: GowthamShanmugam gshanmug@redhat.com