Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while parsing alert_dashboard from grafana 5.0.0 #372

Open
GowthamShanmugam opened this issue Mar 8, 2018 · 4 comments
Open

Error while parsing alert_dashboard from grafana 5.0.0 #372

GowthamShanmugam opened this issue Mar 8, 2018 · 4 comments

Comments

@GowthamShanmugam
Copy link
Collaborator

GowthamShanmugam commented Mar 8, 2018

grafana 5.0.0 supports backward compatibility, It creates alert_dashboard with json which we are passing. And it gives the same json when we send dashboard API request to grafana. problem with the new version is when someone does save operation in grafana directly in grafana then dashboard json is converted to a new version of json. So the alert dashboard logic in monitoring-integration is affected.

in older json all panels are stored under rows, so the json is like

"rows": [
    {
         "panels": [
              {
                // panel json
              },
          ]
     },
]

so now the new json is changed like,

  1. The row is acted like a list. when we try to list panels from UI and press save then json is like
    image
  "panels": [
    {
          type: "row"
          "panels": [
                {
                    "type": "graph"
                    // panel json
                },
          ]
      },
]
  1. when the same row is not listed and saved then json is changed like
    image
"panels": [
   {
       type: "row',
        "panel": [] 
         .
         .
   },
   {
      // panel json
      "type": "graph"
       .
        .
   },
]
@GowthamShanmugam
Copy link
Collaborator Author

@shtripat @nthomas-redhat @r0h4n suggestion please

@r0h4n
Copy link
Contributor

r0h4n commented Mar 14, 2018

Have you checked with the Grafana team about this irregularity? Maybe file an issue on them.

@nthomas-redhat
Copy link
Contributor

Anything related to 5.0.0 is lower priority as we already in agreement that we are not planning to upgrade in the upcoming release. So why testing with version? I suggest to use 4,x,x and worry about this later. @GowthamShanmugam

@GowthamShanmugam
Copy link
Collaborator Author

@nthomas-redhat ok

GowthamShanmugam added a commit to GowthamShanmugam/monitoring-integration that referenced this issue Oct 4, 2018
I did small change to work existing alerting logic to work with
latest grafana.

tendrl-bug-id: Tendrl#372

Signed-off-by: GowthamShanmugasundaram <gshanmug@redhat.com>
GowthamShanmugam added a commit to GowthamShanmugam/monitoring-integration that referenced this issue Jan 14, 2019
I did small change to work existing alerting logic to work with
latest grafana.

tendrl-bug-id: Tendrl#372

Signed-off-by: GowthamShanmugasundaram <gshanmug@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants