Modifying alerting logic based on alert classifications #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnDarshan
reviewed
Oct 26, 2017
| else 'INFO' | ||
| else 'INFO', | ||
| tags={"entity_type": RESOURCE_TYPE_BRICK, | ||
| "volume_name": volumes['volume%s.' 'name' % index] |
There was a problem hiding this comment.
"volume_name": volumes['volume%s.name' % index] ?
There was a problem hiding this comment.
to get volume name using index., referred this line https://github.com/GowthamShanmugam/gluster-integration/blob/a5f1a74937d7ff03dd3857705e415ee33bdfde86/tendrl/gluster_integration/sds_sync/__init__.py#L359
|
@shtripat @nnDarshan @r0h4n please review |
r0h4n
previously approved these changes
Oct 26, 2017
GowthamShanmugam
force-pushed
the
alerting_classification
branch
2 times, most recently
from
a68134b
to
33f9a64
Compare
tendrl-bugid: Tendrl#452 Signed-off-by: GowthamShanmugam <gshanmug@redhat.com>
tendrl-bugid: Tendrl#452 Signed-off-by: GowthamShanmugam <gshanmug@redhat.com>
GowthamShanmugam
force-pushed
the
alerting_classification
branch
from
33f9a64
to
ca89626
Compare
r0h4n
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tendrl-bugid: #452
tendrl-bugid: #449
Signed-off-by: GowthamShanmugam gshanmug@redhat.com