Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pymysql): use pymysql instead of mysql-client #964

Merged
merged 5 commits into from
Sep 24, 2024
Merged

fix(pymysql): use pymysql instead of mysql-client #964

merged 5 commits into from
Sep 24, 2024

Conversation

wklken
Copy link
Collaborator

@wklken wklken commented Sep 24, 2024

Description

Fixes # (issue)

Checklist

  • 填写 PR 描述及相关 issue (write PR description and related issue)
  • 代码风格检查通过 (code style check passed)
  • PR 中包含单元测试 (include unit test)
  • 单元测试通过 (unit test passed)
  • 本地开发联调环境验证通过 (local development environment verification passed)

@wklken wklken requested a review from Han-Ya-Jun September 24, 2024 10:19
Han-Ya-Jun
Han-Ya-Jun approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Han-Ya-Jun Han-Ya-Jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wklken wklken merged commit 88dc9f4 into TencentBlueKing:master Sep 24, 2024
4 checks passed
@wklken wklken deleted the fix_use_pymysql branch September 24, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Han-Ya-Jun Han-Ya-Jun Han-Ya-Jun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wklken @Han-Ya-Jun