Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(lints): fix make lint for src/dashboard #31

Merged
merged 1 commit into from
Jun 8, 2023
Merged

style(lints): fix make lint for src/dashboard #31

merged 1 commit into from
Jun 8, 2023

Conversation

wklken
Copy link
Collaborator

@wklken wklken commented Jun 8, 2023

Description

修复make lint命令, 确保对所有文件生效(之前调用pre-commit实际上是没有运行的)

其中 no_implicit_optional = false 已录单, 需要单独修复

Checklist

  • 填写 PR 描述及相关 issue (write PR description and related issue)
  • 代码风格检查通过 (code style check passed)
  • PR 中包含单元测试 (include unit test)
  • 单元测试通过 (unit test passed)
  • 本地开发联调环境验证通过 (local development environment verification passed)

@alex-smile
Copy link
Contributor

LGTM

@alex-smile alex-smile merged commit 76b63e6 into TencentBlueKing:master Jun 8, 2023
@wklken wklken deleted the fix_lint branch June 8, 2023 11:45
wklken pushed a commit that referenced this pull request Nov 9, 2023
shuzhenyang pushed a commit to shuzhenyang/blueking-apigateway that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants