Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(plugins): refactor, make 4 plugins right #1013

Merged
merged 7 commits into from
Oct 10, 2024
Merged

refactor(plugins): refactor, make 4 plugins right #1013

merged 7 commits into from
Oct 10, 2024

Conversation

wklken
Copy link
Collaborator

@wklken wklken commented Oct 10, 2024

Description

Fixes # (issue)

Checklist

  • 填写 PR 描述及相关 issue (write PR description and related issue)
  • 代码风格检查通过 (code style check passed)
  • PR 中包含单元测试 (include unit test)
  • 单元测试通过 (unit test passed)
  • 本地开发联调环境验证通过 (local development environment verification passed)

@wklken wklken changed the title refactor(plugins): refactor, refactor(plugins): refactor, make 4 plugins right Oct 10, 2024
@wklken wklken requested a review from Han-Ya-Jun October 10, 2024 03:15
@wklken wklken marked this pull request as ready for review October 10, 2024 07:10
Han-Ya-Jun
Han-Ya-Jun approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@Han-Ya-Jun Han-Ya-Jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/dashboard/apigateway/apigateway/tests/common/plugin/test_plugin_checkers.py Outdated Show resolved Hide resolved
src/dashboard/apigateway/apigateway/tests/common/plugin/test_plugin_checkers.py Show resolved Hide resolved
@wklken wklken merged commit 5d4a42d into TencentBlueKing:master Oct 10, 2024
3 checks passed
@wklken wklken deleted the ft_pre_check_plugin_config branch October 10, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Han-Ya-Jun Han-Ya-Jun Han-Ya-Jun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wklken @Han-Ya-Jun