fix: 修复数据清理中脏数据错误 --story=121862836 #7700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normal-wls
requested changes
Feb 11, 2025
normal-wls
approved these changes
Feb 12, 2025
gcloud/contrib/cleaner/tasks.py
Outdated
| @@ -146,10 +149,20 @@ def archive_expired_v2_task_data(): | |||
| logger.info(f"[archive_expired_v2_task_data] archived nums: {len(archived_task_instances)}") | |||
| TaskFlowInstance.objects.filter(id__in=task_ids).delete() | |||
| logger.info(f"[archive_expired_v2_task_data] delete task nums: {len(task_ids)}, e.x.: {task_ids[:3]}...") | |||
| PipelineInstance.objects.filter(id__in=pipeline_instance_ids).delete() | |||
| # 删除 PeriodicTaskHistory 模型中遗留的脏数据，避免因为外键约束导致 PipelineInstance 删除失败 | |||
There was a problem hiding this comment.
PeriodicTaskHistory 对 PipelineInstance 有do nothing外键，需要保证引用关系被清除，避免外键约束导致清理失败
过期任务的 periodic_task_history 必定可清理
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.