feat: 新增通知渠道拓展 #7545 #7607
Merged
feat: 新增通知渠道拓展 #7545 #7607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normal-wls
requested changes
Nov 13, 2024
normal-wls
requested changes
Nov 13, 2024
gcloud/shortcuts/message/send_msg.py
Outdated
| return "{}/{}".format(BK_CHAT_API_ENTRY, "prod/im/api/v1/send_msg") | ||
|
|
||
| def send(self, executor, notify_type, notify_info, receivers, title, content, email_content=None): | ||
| # 兼容旧数据 |
There was a problem hiding this comment.
这里看上去可以不需要？在 send_message 已经兼容了，bkchat 直接用 content 应该就可以？
gcloud/shortcuts/message/send_msg.py
Outdated
|
|
||
| return True | ||
|
|
||
| def send_bkchat(self, notify, content=None): |
normal-wls
approved these changes
Nov 13, 2024
normal-wls
merged commit c55800c
into
TencentBlueKing:feature_ip_selector_master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.