fix: fix the error of image rotating too many times after reseting image #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylsaint
requested review from
honkinglin,
uyarn,
carolin913,
HaixingOoO,
NWYLZW and
ZWkang
as code owners
|
|
uyarn
approved these changes
Sep 18, 2024
lrwlf
reviewed
Sep 19, 2024
| }, []); | ||
|
|
||
| const onResetRotate = useCallback(() => setRotateZ(0), []); | ||
| const onResetRotate = useCallback(() => { | ||
| let degreeToRotate = rotRef.current % 360; |
There was a problem hiding this comment.
Maybe we should take the remainder of 360 every time we rotate, instead of calculating it when resetting？
There was a problem hiding this comment.
purpose of calculating the degree is to get the minimal rotating degree to which can be divided by 360° exactly. In Tdesign react, the image rotate anti-clockwise, so there are four angle remainders which are 0, -90, -180, -270. If remainder is -270, it will cause image to rotate 270°, that's why calculating happens. The calculating will always get the minimal degree to rotate.
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
要解决的问题：修复图片预览旋转多次之后，点击重置后，图片旋转太多次的问题
实现方案：修改 useRotate 这个 hooks， 旋转多次之后， 寻找到离整除 360° 最近的角度，进行旋转， 而不是强制的将角度设置为 0
修改前:
screencast-tdesign_tencent_com-2024_09_18-17_41_37.webm
修改后：
screencast-localhost_15000-2024_09_18-17_42_35.webm
📝 更新日志
fix(组件名称): ImageViewer
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单