-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(card): loading属性增加TNode支持 #3051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangchen1031
requested review from
honkinglin,
uyarn,
carolin913,
HaixingOoO,
NWYLZW and
ZWkang
as code owners
August 20, 2024 09:08
/update-snapshot |
uyarn
added
⛔️ pending
the issue won't be processed right now
and removed
⛔️ pending
the issue won't be processed right now
labels
Aug 22, 2024
這樣判斷去掉loading-parent,要不沒loading也有 let childrenNode:React.ReactNode = null;
if(!Reflect.has(props,'loading')){
childrenNode = React.cloneElement(card, { style })
} else {
if(React.isValidElement(children)){
childrenNode = React.cloneElement(loading, null,children)
} else {
childrenNode = <Loading {...loadingProps} loading={!!loading}>{card}</Loading>
}
} |
huangchen1031
force-pushed
the
fix/card
branch
from
August 30, 2024 08:12
dbc25ff
to
3faacb3
Compare
猴到老,学到老。已经加上这段逻辑! |
@uyarn 看看test,我的windows看不了 |
/update-snapshot |
看了下是图标的更新导致的快照差异,这个PR没其他问题,可以合并了,快照的另提个PR修复下 |
uyarn
approved these changes
Aug 31, 2024
This was referenced Sep 12, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2997
🤔 这个 PR 的性质是?
🔗 相关 Issue
#2997
💡 需求背景和解决方案
📝 更新日志
fix(card): loading属性增加TNode支持
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单