Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm compliant package.json #631

Merged
merged 5 commits into from
May 11, 2016
Merged

npm compliant package.json #631

merged 5 commits into from
May 11, 2016

Conversation

milkandsour
Copy link

In order to be able to install rapidjson via npm, I added a package.json and an include_dirs.js as a main.

I use rapidjson for my own project and I find very useful to install it from npm, also you will have more visibility if you actually publish the package on the npm repo.

@coveralls
Copy link

coveralls commented May 9, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling f8df637 on milkandsour:master into c02d52a on miloyip:master.

@miloyip
Copy link
Collaborator

miloyip commented May 10, 2016

I have no idea about NPM for C++ library. Is it suitable?

@milkandsour
Copy link
Author

Yes it is!
In order to create your own nodejs native extension (addon), you need to
write c++ code and that is because nodejs is written on top of v8, that is
a c++ engine.
Native exension are not so common, but if you seek performance, that is the
way, legacy c++ code also could be the case to go native.
Npm give you the ability to use the install command to compile and install
addons (via node-gyp), or just include it, as I did for rapidjson, via
package.json.
Rapidjson it is the fastest, cause the sax skills, I did not run a
comparison but I think it will kill the v8 JSON native.

Anyway, I do not want to force you, tha was just a pull request shaped
suggestion, I did my own fork and,
in case I will decide to use the library:
I will certainly make the necessary endorsements
I will use it "for Good, not Evil" (cit. license)

2016-05-10 6:22 GMT+01:00 Milo Yip notifications@github.com:

I have no idea about NPM for C++ library. Is it suitable?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#631 (comment)

@miloyip miloyip merged commit 2a3fbda into Tencent:master May 11, 2016
@miloyip
Copy link
Collaborator

miloyip commented May 11, 2016

OK. Thank you.

@gggin
Copy link

gggin commented May 13, 2016

@milkandsour
how to use this packjson in npm
will you give us a document?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants