Introduce comments support #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (is.Peek() == '*') { | ||
| is.Take(); | ||
| while (is.Take() != '*' || is.Take() != '/') { } |
There was a problem hiding this comment.
It seems need to check for null terminator here. Otherwise a malformed input with only open /* may read after null terminator.
* Comments parsing function correctly handles EOF. * Since SkipWhitespaceAndComments can generate errors, its calls should be followed by RAPIDJSON_PARSE_ERROR_EARLY_RETURN macro. * Some tests to make the bug never appear again.
|
Fixed. Also added some tests to check this bug. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find support of comments in JSON very useful, especially when one uses JSON as a format for config files. This PR provides a prototype implementation of this feature.
By default comments support is disabled. One should use a new flag
kParseCommentsFlagto enable the feature, so this implementation is backward compatible and doesn't weaken the standard compliance by default.