Issue23errorcode #27
Merged
Issue23errorcode #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse errors is represented as enum type `ParseErrorCode`. Error texts are optional for user. Added `GetParseError_En()` in `error/en.h`, user can localize this file into other files. User may dynamically change the locale in runtime.
… tests about error code
|
I have not added I would like to invite @pah to review this pull request before merge. Thank you. |
|
👍 As I said in #23, I like this approach. |
|
Oh. I accidentally closed it without merging. I will try merge it. |
Conflicts: example/condense/condense.cpp include/rapidjson/reader.h test/unittest/readertest.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23. Error messages for parsing are changed to error code (
ParseErrorCode).Therefore, the error codes are possible to be handled by code instead of human.
Also, the text messages are provided optionally. This has two advantages:
Unit tests are modified to verify the error codes of synthetic error cases.
Examples are modified for API changes.
API changes:
const char* Reader::GetParseError() const.ParseErrorCode Reader::GetParseErrorCode() const.RAPIDJSON_PARSE_ERRORRAPIDJSON_PARSE_ERROR_NORETURNmacro. User should customize this macro instead ofRAPIDJSON_PARSE_ERRORin the past.