Fix #5741 don't crash when vkCreateDevice fails #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5742 +/- ##
===========================================
- Coverage 94.58% 89.98% -4.60%
===========================================
Files 787 265 -522
Lines 248626 78776 -169850
===========================================
- Hits 235164 70887 -164277
+ Misses 13462 7889 -5573 ☔ View full report in Codecov by Sentry. |
nihui
requested changes
Oct 17, 2024
nihui
approved these changes
Oct 18, 2024
|
Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should fix #5741 and prevent crash if vkCreateDevice fails or unable to create dummy buffer image.