-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add destroy_gpu_instance() function new parameter need_wait about it will wait for all devices to be idle before destroy #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from 100000 to 1000.
…will wait for all devices to be idle before destroy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4763 +/- ##
===========================================
- Coverage 95.19% 89.57% -5.62%
===========================================
Files 722 262 -460
Lines 216951 74230 -142721
===========================================
- Hits 206525 66494 -140031
+ Misses 10426 7736 -2690 ☔ View full report in Codecov by Sentry. |
… are idle before proceeding with destruction.
@nihui Updated. Delete the parameter need_wait of the destroy_gpu_instance() function. Before: NCNN_EXPORT void destroy_gpu_instance(int need_wait = 0); After: NCNN_EXPORT void destroy_gpu_instance(); |
Thanks for your contribution ! |
senli123
pushed a commit
to senli123/ncnn
that referenced
this pull request
May 7, 2024
…e destroy (Tencent#4763) * destroy_gpu_instance() will internally ensure that all vulkan devices are idle before proceeding with destruction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
书上说,须在销毁设备之前之前调用vkDeviceWaitIdle(),以等待所有设备可能存在的未完成的任何工作。
为了保持向前兼容性,所以默认参数设计成默认不启用。
引用出处: