Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Filter rendering using tgfx::RuntimeProgram. #2733

Merged
merged 9 commits into from
Mar 20, 2025

Conversation

Hparty
Copy link
Collaborator

@Hparty Hparty commented Mar 17, 2025

No description provided.

@Hparty Hparty requested review from domchen and shlzxjp as code owners March 17, 2025 11:16
@Hparty Hparty requested a review from kevingpqi123 as a code owner March 18, 2025 13:19
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 40 lines in your changes missing coverage. Please review.

Project coverage is 77.39%. Comparing base (ae75f4e) to head (d151abe).

Files with missing lines Patch % Lines
src/rendering/renderers/FilterRenderer.cpp 85.10% 10 Missing and 11 partials ⚠️
src/rendering/filters/BulgeFilter.cpp 91.30% 4 Missing and 6 partials ⚠️
src/rendering/filters/LayerStylesFilter.cpp 83.33% 2 Missing and 2 partials ⚠️
src/rendering/filters/RuntimeFilter.cpp 93.54% 1 Missing and 1 partial ⚠️
src/rendering/filters/CornerPinFilter.cpp 98.24% 0 Missing and 1 partial ⚠️
src/rendering/filters/MotionBlurFilter.cpp 98.33% 0 Missing and 1 partial ⚠️
src/rendering/graphics/Canvas.h 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2733      +/-   ##
==========================================
+ Coverage   77.19%   77.39%   +0.20%     
==========================================
  Files         425      419       -6     
  Lines       22467    22268     -199     
  Branches     6357     6365       +8     
==========================================
- Hits        17343    17234     -109     
+ Misses       3815     3776      -39     
+ Partials     1309     1258      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LayerStyle单独绘制,所有的Effect直接构造输出成当前帧的ImageFilter列表,简化FilterRender的逻辑。只处理ImageFilter的生成。

@domchen domchen merged commit 4fe4f97 into main Mar 20, 2025
8 checks passed
@domchen domchen deleted the feature/partyhuang_filter branch March 20, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants