Add CMakeLists.txt and third-party build scripts for PAGViewer #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeJhF
requested review from
kevingpqi123,
domchen,
Hparty and
shlzxjp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2726 +/- ##
==========================================
+ Coverage 77.21% 77.24% +0.03%
==========================================
Files 425 425
Lines 22467 22467
Branches 6357 6357
==========================================
+ Hits 17348 17355 +7
- Misses 3812 3813 +1
+ Partials 1307 1299 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
domchen
reviewed
Mar 14, 2025
Comment on lines
+4
to
+9
| "common": [ | ||
| { | ||
| "url": "https://github.com/libpag/vendor_tools.git", | ||
| "commit": "dd40c12a603b747f912340aecbcd246a99c72ec9", | ||
| "dir": "tools/vendor_tools" | ||
| }, |
domchen
reviewed
Mar 14, 2025
Comment on lines
+15
to
+19
| { | ||
| "url": "https://github.com/DaveGamble/cJSON.git", | ||
| "commit": "76be8fcf15677ca7f6db7c770f5ae6bf8b41d78f", | ||
| "dir": "third_party/cjson" | ||
| } |
There was a problem hiding this comment.
这个上次已经说过了，使用根目录项目已经引用的那个json库，不要新增。
domchen
reviewed
Mar 14, 2025
Comment on lines
+10
to
+14
| { | ||
| "url": "https://github.com/jedisct1/libsodium.git", | ||
| "commit": "9511c982fb1d046470a8b42aa36556cdb7da15de", | ||
| "dir": "third_party/sodium" | ||
| }, |
There was a problem hiding this comment.
这个具体是起到什么作用？看看是否可以不引用。尽可能裁剪掉。否则新增了第三方库都要通过法务更新协议。其他的几个库也检查一下是否已经有替代的功能。可以不用依赖的。
domchen
reviewed
Mar 14, 2025
domchen
reviewed
Mar 14, 2025
There was a problem hiding this comment.
PAG是标准的cmake项目，不要写脚本来编译。vendor_tools直接可以支持配置。
domchen
reviewed
Mar 14, 2025
There was a problem hiding this comment.
你写了太多的编译脚本了。这样维护起来很困难。如果这个第三方库是必须的，可以直接fork一份第三方库代码到我们的libpag组织下，给写个跨平台的CMAKELists配置就好了，一次性支持所有平台的统一编译。除非是Skia这样有自己的编译系统，没法写cmake的我们才不得不写脚本。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、为PAGViewer添加CMakeLists.txt
2、为PAGviewer添加第三方库构建脚本