Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove listening for screen lock and unlock events and add listening for onResume. #116

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

lvpengwei
Copy link
Collaborator

On some Android devices, the screen lock and unlock events are not paired, we can use the activity's onResume callback.

@lvpengwei lvpengwei force-pushed the bugfix/pengweilv_android_pagview branch from 191a837 to c445a77 Compare February 16, 2022 11:00
@codecov-commenter
Copy link

Codecov Report

Merging #116 (191a837) into main (153abc9) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 191a837 differs from pull request most recent head c445a77. Consider uploading reports for the commit c445a77 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   63.84%   63.90%   +0.06%     
==========================================
  Files         555      555              
  Lines       26127    26129       +2     
  Branches     7297     7297              
==========================================
+ Hits        16682    16699      +17     
- Misses       4817     4822       +5     
+ Partials     4628     4608      -20     
Impacted Files Coverage Δ
libpag/tgfx/src/core/vectors/freetype/FTMask.cpp 60.78% <0.00%> (-11.77%) ⬇️
libpag/src/codec/tags/MarkerTag.cpp 55.55% <0.00%> (-7.41%) ⬇️
libpag/src/rendering/caches/FrameCache.h 80.00% <0.00%> (-6.67%) ⬇️
libpag/src/base/utils/TimeUtil.h 48.57% <0.00%> (-5.72%) ⬇️
libpag/tgfx/src/gpu/ProgramCache.cpp 68.57% <0.00%> (-2.86%) ⬇️
libpag/src/base/Transform2D.cpp 69.44% <0.00%> (-2.78%) ⬇️
libpag/src/rendering/graphics/Recorder.cpp 57.89% <0.00%> (-2.11%) ⬇️
libpag/tgfx/src/gpu/opengl/GLUtil.cpp 75.60% <0.00%> (-1.83%) ⬇️
libpag/tgfx/src/gpu/opengl/GLCanvas.cpp 59.85% <0.00%> (-1.49%) ⬇️
libpag/src/rendering/graphics/Graphic.cpp 77.30% <0.00%> (-1.23%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153abc9...c445a77. Read the comment docs.

@lvpengwei lvpengwei force-pushed the bugfix/pengweilv_android_pagview branch from c445a77 to fe0f3da Compare February 16, 2022 11:52
@lvpengwei lvpengwei force-pushed the bugfix/pengweilv_android_pagview branch from fe0f3da to 1500b45 Compare February 17, 2022 02:54
…for onResume.

On some Android devices, the screen lock and unlock events are not paired, we can use the activity's onResume callback.
@lvpengwei lvpengwei force-pushed the bugfix/pengweilv_android_pagview branch from 1500b45 to e925946 Compare February 17, 2022 03:09
@lvpengwei lvpengwei requested a review from domchen February 17, 2022 03:16
Copy link
Contributor

@h3r3x3 h3r3x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domchen domchen merged commit 8f3d2b2 into main Feb 17, 2022
@domchen domchen deleted the bugfix/pengweilv_android_pagview branch February 17, 2022 11:54
@hanbinbin hanbinbin mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants