Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple media matched styles applied and boolean flag can be available #40

Closed
wants to merge 2 commits into from
Closed

Multiple media matched styles applied and boolean flag can be available #40

wants to merge 2 commits into from
+93 −74

Conversation

tkow
Copy link
Contributor

@tkow tkow commented Nov 16, 2022 •
edited
Loading

Fix #39

I also include some improvements of media style handling (extracted styles can processing as batch and the way to determine variants based on guard)

Rules

  • Later styles merge earlier styles and overwrite them if same style properties exist.
  • As like css, latter styles are prioritized. This is subjected to javascript object keys' order.

@tkow tkow mentioned this pull request Nov 16, 2022
Open
@tkow tkow mentioned this pull request Nov 16, 2022
Open
@tkow
Copy link
Contributor Author

tkow commented Nov 16, 2022

Sorry, I've found bug this PR. So, fix it in #42 and close this PR.

@tkow tkow closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix boolean flag based media style handling
1 participant
@tkow