Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Keep MAC address case #384

Closed
Tinyblargon opened this issue Nov 26, 2024 · 0 comments · Fixed by #385
Closed

Feat: Keep MAC address case #384

Tinyblargon opened this issue Nov 26, 2024 · 0 comments · Fixed by #385
Assignees
@Tinyblargon
Labels
type/enhancement An improvement of existing functionality

Comments

@Tinyblargon
Copy link
Collaborator

Tinyblargon commented Nov 26, 2024 •
edited
Loading

Currently with the Qemu network interfaces, when updating a mac address we force it to be lower case. We should preserve the value in pve if the binary value of the mac address is the same.

Changing the case of the mac address is treated the same way as assigning a new mac address.
@Tinyblargon Tinyblargon added the type/enhancement An improvement of existing functionality label Nov 26, 2024
@Tinyblargon Tinyblargon self-assigned this Nov 26, 2024
@Tinyblargon Tinyblargon mentioned this issue Nov 26, 2024
Merged
Tinyblargon added a commit that referenced this issue Nov 27, 2024
@Tinyblargon
Merge pull request #385 from Tinyblargon/#384
af1f4e8 
feat: use same mac address case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tinyblargon Tinyblargon

Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use same mac address case Tinyblargon/proxmox-api-go
1 participant
@Tinyblargon