Allow not auto-opening browser for oauth workflow #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Braastos
suggested changes
May 28, 2024
| while self._user_token is None: | ||
| await asyncio.sleep(0.01) | ||
| else: | ||
| self.logger.info(f"To authenticate open: {self._build_auth_url()}") |
There was a problem hiding this comment.
Not sure if logging the url is needed, because you can retrieve the url with return_auth_url() method from your own code.
There was a problem hiding this comment.
So the reason why I want to log the url here is that the .authenticate( call is blocking as it is opening a listener for the response from twitch. You are right that the calling code could run .return_auth_url( before calling authenticate to present the url to the user, but I think it is helpful to not require the calling code to know it needs to do so, and logging the data info will usually be visible if the user if running via the CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have multiple browser profiles and would like to manually choose which profile to open the oauth workflow in, but the auto-open browser library doesn't provide that granular level of control. Because of that I'd like to have the option to simply print the url to open to the log and then I can manually open that url in the browser tab of my choice.