Allow manual_unwrap_or_default in all generated impls #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2024
martin-g
added a commit
to apache/avro
that referenced
this pull request
Jul 12, 2024
…ing dependency Introduced-with: 2c484c6 Fixed upstream with: TedDriggs/darling#296 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
added a commit
to apache/avro
that referenced
this pull request
Jul 12, 2024
…ing dependency (#3018) Introduced-with: 2c484c6 Fixed upstream with: TedDriggs/darling#296 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
added a commit
to apache/avro
that referenced
this pull request
Jul 12, 2024
…ing dependency (#3018) Introduced-with: 2c484c6 Fixed upstream with: TedDriggs/darling#296 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> (cherry picked from commit 69cd998)
andrei-ng
added a commit
to plotly/plotly.rs
that referenced
this pull request
Jul 31, 2024
- temporary patch introduced in 3130f5a to bypass clippy errors due to darling package: TedDriggs/darling#296 Closes #210 Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
andrei-ng
added a commit
to plotly/plotly.rs
that referenced
this pull request
Jul 31, 2024
* update contributing file with new contact details Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com> * provide alternative show_html method - the show() method by default creates a random named file in `/tmp` dir, however in some cases `/tmp` is not available, e.g., snap's Firefox runs in an isolated enviroment and cannot access the system's `/tmp` - provide a method that calls write_html followed by show for easier access Closes #170 Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com> * fix clippy & fmt warnings Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com> * revert CI clippy darling package command patch - temporary patch introduced in 3130f5a to bypass clippy errors due to darling package: TedDriggs/darling#296 Closes #210 Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com> --------- Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
martin-g
added a commit
to apache/avro-rs
that referenced
this pull request
Sep 23, 2024
…ing dependency (#3018) Introduced-with: apache/avro@2c484c6 Fixed upstream with: TedDriggs/darling#296 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.