Fix some missing syn invisible group handling in FromMeta implementations #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was supposed to be fixed by c036162 but it looks like this implementation was forgotten.
Ten0
added a commit
to Ten0/darling
that referenced
this pull request
Feb 8, 2024
It's currently named "Unexpected litteral type", but it can also be instantiated when not parsing a litteral, e.g. https://github.com/TedDriggs/darling/blob/224a866727cd9e40c2cd80430852b1ea0deeb40e/core/src/error/mod.rs#L152 This specifically made investigation of TedDriggs#263 more difficult.
This was referenced Feb 8, 2024
Ten0
force-pushed
the
fix_missing_syn_invisible_group_handling
branch
from
2ccf283
to
aecdfec
Compare
Ten0
changed the title
TedDriggs
requested changes
Feb 12, 2024
TedDriggs
pushed a commit
that referenced
this pull request
Feb 12, 2024
It's currently named "Unexpected litteral type", but it can also be instantiated when not parsing a litteral, e.g. https://github.com/TedDriggs/darling/blob/224a866727cd9e40c2cd80430852b1ea0deeb40e/core/src/error/mod.rs#L152 This specifically made investigation of #263 more difficult.
|
As of syn 2.40, syn may generate this invisible token when the input to the darling proc macro (specifically, the attributes) are generated by a |
|
Okay, can you add that as a comment in the source code with each of these changes so that it's clear later why this is going on? |
TedDriggs
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was supposed to be fixed by c036162 but it looks like these implementations were forgotten.