Improve `FromMeta` implementation for enums #260

davidsemakula · 2023-12-28T07:15:28Z

Improves FromMeta implementation for enums

Properly implement unit arms in FromMeta::from_list to provide a consistent API for heterogenous enums that include a mix of unit, newtype and struct variants (see included test for an example).
Add #[darling(word)] for unit enum variants (See Add #[darling(word)] for enum variants #63).
Adds tests for behavior of FromMeta implementation for enums.

tests/from_meta.rs

core/src/codegen/from_meta_impl.rs

tests/from_meta.rs

…SRV issue

davidsemakula · 2024-01-02T18:57:34Z

I'm working on implementing support for #[darling(word)] syntax

core/src/options/input_variant.rs

core/src/codegen/from_meta_impl.rs

TedDriggs

I am very excited about where this is heading; thank you for the latest updates. Feedback is now starting to get more specific, so I think we're closing in on readiness to merge.

core/src/codegen/from_meta_impl.rs

core/src/options/input_variant.rs

core/src/options/from_meta.rs

tests/compile-fail/duplicate_word_accross_variants.rs

davidsemakula · 2024-01-03T17:35:59Z

LMK if I should squash the commits 🙂

TedDriggs

The only remaining items are:

Deciding if this is the best name for this attribute. I thought it was originally (and I still don't think default is appropriate), but I am now worrying that word is too cryptic.
Updating the CHANGELOG
Updating the README

core/src/options/input_variant.rs

TedDriggs · 2024-01-03T18:51:04Z

LMK if I should squash the commits 🙂

I think we're very close to the squash point.

davidsemakula · 2024-01-03T20:21:38Z

I'll work on the changelog and readme updates tomorrow.

Deciding if this is the best name for this attribute. I thought it was originally (and I still don't think default is appropriate), but I am now worrying that word is too cryptic.

Agreed, default would be confusing and word is a bit cryptic, but I don't have a better suggestion at this point. May be the more verbose from_word?

davidsemakula · 2024-01-04T09:15:29Z

I updated the changelog. But I don't think I can update the readme to introduce and describe #[darling(word)] succinctly, can you take that part? I'm guessing it should be a bullet point under Features?

TedDriggs · 2024-01-05T15:19:26Z

In the absence of a README entry, we could consider an example that includes several features of a heterogeneous enum. Maybe replicate one of the tests over to the examples and add some comments to show what's going on?

davidsemakula · 2024-01-05T15:37:22Z

Sounds good, I'll work on an example 👍

…he #[darling(word)]

davidsemakula · 2024-01-11T16:44:25Z

In the absence of a README entry, we could consider an example that includes several features of a heterogeneous enum. Maybe replicate one of the tests over to the examples and add some comments to show what's going on?

Added an example.

davidsemakula · 2024-01-18T08:44:06Z

Pinging @TedDriggs

TedDriggs

Very minor changes left, then we're ready to merge!

Apologies for the delayed review, I was traveling last week and getting caught up at work this week.

core/src/options/from_meta.rs

core/src/options/input_variant.rs

core/src/options/mod.rs

davidsemakula · 2024-01-25T19:13:40Z

@TedDriggs can we get this published on crates.io when you have some time?
If I can do anything to help that process along, LMK 🙂

TedDriggs · 2024-01-25T19:53:51Z

Will do on Monday; out of town this weekend

…

________________________________ From: David Semakula ***@***.***> Sent: Thursday, January 25, 2024 11:13:50 AM To: TedDriggs/darling ***@***.***> Cc: Ted Driggs ***@***.***>; Mention ***@***.***> Subject: Re: [TedDriggs/darling] Improve `FromMeta` implementation for enums (PR #260) @TedDriggs<https://github.com/TedDriggs> can we get this published on crates.io when you have some time? If I can do anything to help that process along, LMK 🙂 — Reply to this email directly, view it on GitHub<#260 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABEVHRZWVZUL6IB6CGXY5STYQKVG5AVCNFSM6AAAAABBFFQZJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQHAZDKNZRGY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

TedDriggs · 2024-01-29T21:51:11Z

v0.20.4 is now live.

davidsemakula · 2024-01-30T01:49:28Z

Awesome! Thanks for taking the time to review this PR 🙂

Improve FromMeta implementation for enums

233b60c

davidsemakula force-pushed the from-meta-enum branch from 053e722 to 233b60c Compare December 28, 2023 12:20

TedDriggs requested changes Jan 2, 2024

View reviewed changes

tests/from_meta.rs Outdated Show resolved Hide resolved

core/src/codegen/from_meta_impl.rs Outdated Show resolved Hide resolved

TedDriggs reviewed Jan 2, 2024

View reviewed changes

tests/from_meta.rs Outdated Show resolved Hide resolved

Revert FromMeta::from_string implementation and impl Default to fix M…

95232f2

…SRV issue

Add #[darling(word)] for unit enum variants

5648926

davidsemakula requested a review from TedDriggs January 2, 2024 20:19

TedDriggs reviewed Jan 2, 2024

View reviewed changes

core/src/options/input_variant.rs Outdated Show resolved Hide resolved

core/src/codegen/from_meta_impl.rs Show resolved Hide resolved

core/src/codegen/from_meta_impl.rs Outdated Show resolved Hide resolved

core/src/codegen/from_meta_impl.rs Outdated Show resolved Hide resolved

davidsemakula added 3 commits January 3, 2024 10:42

FromMeta implementation style improvements

2356ac2

Improve #[darling(word)] validation

99f3597

Add another #[darling(word)] ui test

e28928b

davidsemakula requested a review from TedDriggs January 3, 2024 13:57

TedDriggs requested changes Jan 3, 2024

View reviewed changes

davidsemakula added 3 commits January 3, 2024 18:53

Update #[darling(word)] duplicate error message and fix ui tests

f34bce6

Revert FromMeta::from_list behaviour for empty lists

3a5a633

Refactor FromMeta enum tests

778b58b

davidsemakula requested a review from TedDriggs January 3, 2024 17:34

TedDriggs reviewed Jan 3, 2024

View reviewed changes

core/src/options/input_variant.rs Show resolved Hide resolved

Update changelog

3160677

davidsemakula added 2 commits January 8, 2024 14:11

Add example for deriving FromMeta for heterogeneous enums and using t…

3f07d29

…he #[darling(word)]

Update custom error to use #[darling(word)]

b95551c

davidsemakula requested a review from TedDriggs January 8, 2024 11:14

TedDriggs approved these changes Jan 19, 2024

View reviewed changes

core/src/options/from_meta.rs Outdated Show resolved Hide resolved

core/src/options/from_meta.rs Outdated Show resolved Hide resolved

core/src/options/input_variant.rs Show resolved Hide resolved

core/src/options/mod.rs Outdated Show resolved Hide resolved

davidsemakula added 2 commits January 19, 2024 20:00

Update #[darling(word)] ui test

03d781a

Style and docs improvements

e27d2f7

davidsemakula requested a review from TedDriggs January 19, 2024 17:04

TedDriggs approved these changes Jan 19, 2024

View reviewed changes

TedDriggs merged commit 6118a83 into TedDriggs:master Jan 19, 2024
12 checks passed

davidsemakula deleted the from-meta-enum branch January 19, 2024 20:16

davidsemakula mentioned this pull request Jan 30, 2024

Improve syntax for ink! e2e runtime_only attribute argument use-ink/ink#2083

Merged

5 tasks

Sufflope mentioned this pull request Sep 20, 2024

Unknown fields are ignored in unit enum variants #306

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve `FromMeta` implementation for enums #260

Improve `FromMeta` implementation for enums #260

davidsemakula commented Dec 28, 2023 •

edited

Loading

davidsemakula commented Jan 2, 2024

TedDriggs left a comment

davidsemakula commented Jan 3, 2024

TedDriggs left a comment

TedDriggs commented Jan 3, 2024

davidsemakula commented Jan 3, 2024

davidsemakula commented Jan 4, 2024

TedDriggs commented Jan 5, 2024

davidsemakula commented Jan 5, 2024

davidsemakula commented Jan 11, 2024

davidsemakula commented Jan 18, 2024

TedDriggs left a comment

davidsemakula commented Jan 25, 2024

TedDriggs commented Jan 25, 2024 via email

TedDriggs commented Jan 29, 2024

davidsemakula commented Jan 30, 2024

Improve FromMeta implementation for enums #260

Improve FromMeta implementation for enums #260

Conversation

davidsemakula commented Dec 28, 2023 • edited Loading

davidsemakula commented Jan 2, 2024

TedDriggs left a comment

Choose a reason for hiding this comment

davidsemakula commented Jan 3, 2024

TedDriggs left a comment

Choose a reason for hiding this comment

TedDriggs commented Jan 3, 2024

davidsemakula commented Jan 3, 2024

davidsemakula commented Jan 4, 2024

TedDriggs commented Jan 5, 2024

davidsemakula commented Jan 5, 2024

davidsemakula commented Jan 11, 2024

davidsemakula commented Jan 18, 2024

TedDriggs left a comment

Choose a reason for hiding this comment

davidsemakula commented Jan 25, 2024

TedDriggs commented Jan 25, 2024 via email

TedDriggs commented Jan 29, 2024

davidsemakula commented Jan 30, 2024

Improve `FromMeta` implementation for enums #260

Improve `FromMeta` implementation for enums #260

davidsemakula commented Dec 28, 2023 •

edited

Loading