Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make darling_core::options and darling_core::codegen crate-private #58

Closed
TedDriggs opened this issue Feb 6, 2019 · 0 comments
Closed

Make darling_core::options and darling_core::codegen crate-private #58

TedDriggs opened this issue Feb 6, 2019 · 0 comments
Milestone
0.9.0

Comments

@TedDriggs
Copy link
Owner

Once #57 is complete, there's no reason for darling_core to expose its code generation structs to the outside world. Hiding these will make refactoring easier without fear of breaking changes.
@TedDriggs TedDriggs added this to the 0.9.0 milestone Feb 6, 2019
TedDriggs added a commit that referenced this issue Mar 19, 2019
@TedDriggs
Make darling_core::{codegen, options} crate-private
316066e 
This will make internal refactoring easier going forward.

This change also removes dead code exposed by making the crates private.

Fixes #58
@TedDriggs TedDriggs mentioned this issue Mar 19, 2019
Closed
TedDriggs added a commit that referenced this issue Mar 20, 2019
@TedDriggs
Make darling_core::{codegen, options} crate-private
038614f 
This will make internal refactoring easier going forward.

This change also removes dead code exposed by making the crates private.

Fixes #58
@TedDriggs TedDriggs mentioned this issue Mar 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@TedDriggs