Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change addons-install for a better CLI experience #89

Merged
merged 5 commits into from
Oct 31, 2017

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Oct 9, 2017

It turns out for linters you possibly need full path of addon.

Current CLI was not very sane, changing it since it's a young feature that I don't expect to be used widely out there.

@yajo yajo self-assigned this Oct 9, 2017
Includes fix for currently broken CI, where some code is getting
removed because environment variables never match at build time.
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once you're 🍏

@yajo
Copy link
Contributor Author

yajo commented Oct 31, 2017

It seems the v11 build (the only one in debian:9) is getting hit by travis-ci/travis-ci#7401

@yajo yajo merged commit 6c7d2e0 into master Oct 31, 2017
@yajo yajo deleted the addons-install-changed branch October 31, 2017 10:01
@yajo
Copy link
Contributor Author

yajo commented Oct 31, 2017

🎉 This is a good step to get a doodba-quality-tools project up! (oops, spoiler!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants