Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for $AUTO_REQUIREMENTS #175

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Drop support for $AUTO_REQUIREMENTS #175

merged 2 commits into from
Oct 11, 2018

Commits on Oct 11, 2018

  1. Drop support for $AUTO_REQUIREMENTS

    This feature was introduced in #71, but time has proven it buggy and not much useful.
    
    This feature has a chicken-and-egg problem in the devel environment: code doesn't exist at build time, but it is expected to be able to find the `requirements.txt` files inside it.
    
    It confuses the developer and creates divergencies between devel and test/prod environments (where that problem doesn't exist).
    
    Also it's breaking #174, which is a more important and actually used feature.
    
    The best fix is to drop support for this. If you really want to have requirements from remotes, you can add this to your `dependencies/pip.txt` file:
    
    ```
    # Assuming you are installing all from server-tools
    -r https://raw.githubusercontent.com/OCA/server-tools/11.0/requirements.txt
    ```
    
    It's a better choice because:
    
    - It's basic official pip.
    - It's explicit.
    - It works fine across environments.
    yajo committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    1d5aaf2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    967ae62 View commit details
    Browse the repository at this point in the history