Saner auto requirements installation

- Shortcut for installation that reduces the logic size.
- Cannot install from repositories before aggregation.
- Auto dependencies should come in before manual ones.
- Drop support of deprecated /opt/custom/src/requirements.txt file.

build.d/200-dependencies

@@ -0,0 +1,28 @@
+#!/usr/bin/env python
+# Copyright 2017 LasLabs Inc.
+
+from os.path import join
+
+from odoobaselib import (
+    addons_config,
+    AUTO_REQUIREMENTS,
+    CUSTOM_DIR,
+    FILE_APT_BUILD,
+    SRC_DIR,
+)
+from odoobaselib.installer import install, INSTALLERS
+
+
+# Build dependencies installed before any others
+install("apt", FILE_APT_BUILD)
+
+for name in INSTALLERS:
+    req_files = []
+    # pip `requirements.txt` files found in repositories
+    if name == "pip" and AUTO_REQUIREMENTS:
+        for repo in addons_config():
+            req_files.append(join(SRC_DIR, repo, 'requirements.txt'))
+    # Normal dependency installation
+    req_files.append(join(CUSTOM_DIR, 'dependencies', '%s.txt' % name))
+    for req_file in req_files:
+        install(name, req_file)

lib/odoobaselib/installer.py

@@ -26,10 +26,12 @@ def cleanup(self):
     def install(self):
         """Install the requirements from the given file."""
         if self._requirements:
-            self._run_command(self._install_command + self._requirements)
+            return not self._run_command(
+                self._install_command + self._requirements)
         else:
             logging.info("No installable requirements found in %s",
                          self.file_path)
+        return False
 
     def remove(self):
         """Uninstall the requirements from the given file."""
@@ -102,7 +104,7 @@ class PipInstaller(Installer):
 
     def requirements(self):
         """Pip will use its ``--requirements`` feature."""
-        return [self.file_path]
+        return [self.file_path] if exists(self.file_path) else []
 
 
 INSTALLERS = {
@@ -111,3 +113,8 @@ def requirements(self):
     "npm": NpmInstaller,
     "pip": PipInstaller,
 }
+
+
+def install(installer, file_path):
+    """Perform a given type of installation from a given file."""
+    return INSTALLERS[installer](file_path).install()