-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create template for application form and form details pages #538
Create template for application form and form details pages #538
Conversation
this PR is now ready for review 🎉 @derekhouck @ChasVanDav @daaimah123 |
…htonica's style guide
…be on the same line
…ection to be on the same line
…app-form.html to keep UI consistent across the site
…han 0, 25000 or must be a whole number
caf1951
to
f6ef8f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steph, as always your code is clean as a whistle with easy-to-follow naming choices on those routes. Double check my comments on the content and then you shall be g2g!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent start, but I want this to be followed up by several other PRs addressing things like adding the Javascript to the page instead of an external script, add styles to the page instead of an external SASS file, and adding conditional logic throughout so that you don't have to front-load all the requirements language. I encourage you and anyone else involved with this form project to read through UK's documentation on Structuring forms. In particular, pay attention to their "one thing per page" philosophy. We want to guide potential participants through the process as much as possible and not overwhelm them with text or fields.
You are eligible to apply for Techtonica’s full-time program if you: | ||
</p> | ||
<ul> | ||
<li> | ||
are a woman (cis OR trans) or non-binary adult. We especially | ||
encourage Latinx, Black, and non-binary folks to apply. | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent opportunity to implement some conditional logic and cut down on the walls of eligibility text and form fields. A gender identity question can be used to quickly disqualify anyone whose gender identity does not line up with the eligibility requirements, saving them an immense amount of time on a form they do not need to fill out. If they answer with an eligible value, move them onto the rest of the form. If they answer with a non-eligible value, show them copy similar to this and send them off on their way.
Hey @derekhouck fantastic suggestions. We have some issues dependent upon this work (#555, #556, #557, #558, & #559) and I'd love to see this iterated on in another PR. Created #567 to tackle your last comments, feel free to add to the issue as it was a quick spin up. @stmcpeters I have some incoming style change suggestions... |
@stmcpeters, @mai-repo is handling many of the style concerns I had, go ahead and merge this in |
text requesting review is placeholder text
Changes in this PR have successfully been merged into |
Description
This PR addresses issue #389 that aims to create a user-friendly, responsive form for applicants to apply directly on techtonica.org.
Objective
These changes are important because:
Demo
Screen.Recording.2025-01-31.at.12.17.55.PM.mov
Changes Made
/app-form-details
) using placeholder text and/or current text used on Techtonica's website (this will be changed by program staff later).<input type="email">
,<input type="tel">
).Next Steps
app-form-details.html
andapp-form.html
Additional Notes
app-form.html
while still in review stage, rather than being added directly to the project's JS files.app-form-details.html
andapp-form.html
), while the project's issues with the SASS and CSS files are being investigated in #554.Chances for Improvement/Questions
white-space: pre-wrap;
to preserve whitespace and line breaks, but commented this out due to readability issues. Below, the left screenshot displays the tooltips with the carriage returns and the right screenshot does not utilizewhite-space: pre-wrap;