Fix calculated end chapter number for books with prologues

TechWilk · Nov 13, 2024 · 67d2fe1 · 67d2fe1
1 parent 60cb795
commit 67d2fe1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/BiblePassageParser.php b/src/BiblePassageParser.php
@@ -111,7 +111,7 @@ public function parse(string $versesString): array
 
             if (1 === count($splitSection)) {
                 $endBookObject = $this->getBookFromAbbreviation($lastBook);
-                $endChapterForReference = (int) ($lastChapter ?? $endBookObject->chaptersInBook());
+                $endChapterForReference = (int) ($lastChapter ?? array_key_last($endBookObject->chapterStructure()));
                 $toReference = new BibleReference(
                     $endBookObject,
                     $endChapterForReference,

diff --git a/tests/ParserCatholicStructureTest.php b/tests/ParserCatholicStructureTest.php
@@ -684,6 +684,12 @@ public function providerVerses(): array
                     ['Sirach 0:1', 'Sirach 0:1'],
                 ],
             ],
+            // 'sirach whole book including prologue' => [
+            //     'Sirach',
+            //     [
+            //         ['Sirach 0:1', 'Sirach 51:30'],
+            //     ],
+            // ],
         ];
     }