Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/issue 24/archived sessions page #292

Merged
merged 8 commits into from
Nov 22, 2023

Conversation

nzeager
Copy link
Member

@nzeager nzeager commented Nov 19, 2023

Pull Request Template

1. Targeted Issue

Users want to see past session information.

Issue #285

2. Overview of Solution

I added a component to display archived sessions. I based it on the components we already have to display upcoming sessions, but adjusted the styling for the needs of this component.

3. Tools Used

Pagination, UseStates, UseEffects, axios request

4. Testing Strategy

Displayed component with and without results and tested pagination buttons

5. Future Implications

We may want to add more user functionality down the line, such as sorting the sessions by most or least recent, mentor name, etc. This could potentially be easier if we switch our sessions to MUI's table component: https://mui.com/material-ui/react-table/#custom-pagination-options

6. Screenshots

Nothing notable, but here's how it looks.
Screenshot 2023-11-19 at 11 38 14 AM

7. Code Reviewers

n/a

Copy link

netlify bot commented Nov 19, 2023

Deploy Preview for staging-momentors ready!

Name Link
🔨 Latest commit 3adf4b5
🔍 Latest deploy log https://app.netlify.com/sites/staging-momentors/deploys/655a3a4733d6ec0008801b2c
😎 Deploy Preview https://deploy-preview-292--staging-momentors.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@GitLukeW GitLukeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looks good. Approved on my end.

Copy link
Collaborator

@esparr esparr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to go ahead and approve this PR. I had issues running it but others did not. I will need to debug my local dev env for the FE but I don't want it to hold this up. I will test it further in staging.

@esparr esparr merged commit 94728e9 into staging Nov 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants