-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/issue 24/archived sessions page #292
Conversation
…sessions, but currently displays sessions page info
…and console logged the results
✅ Deploy Preview for staging-momentors ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update looks good. Approved on my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to go ahead and approve this PR. I had issues running it but others did not. I will need to debug my local dev env for the FE but I don't want it to hold this up. I will test it further in staging.
Pull Request Template
1. Targeted Issue
Users want to see past session information.
Issue #285
2. Overview of Solution
I added a component to display archived sessions. I based it on the components we already have to display upcoming sessions, but adjusted the styling for the needs of this component.
3. Tools Used
Pagination, UseStates, UseEffects, axios request
4. Testing Strategy
Displayed component with and without results and tested pagination buttons
5. Future Implications
We may want to add more user functionality down the line, such as sorting the sessions by most or least recent, mentor name, etc. This could potentially be easier if we switch our sessions to MUI's table component: https://mui.com/material-ui/react-table/#custom-pagination-options
6. Screenshots
Nothing notable, but here's how it looks.
7. Code Reviewers
n/a