Edit mentor team async await #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 4ef496c |
jimbandrews
force-pushed
the
EditMentorTeamAsyncAwait
branch
from
d24bde9 to
4ef496c
Compare
GitLukeW
approved these changes
Oct 25, 2023
| onChange={(e) => setTeamNumber(e.target.value)} | ||
| ></TextField> | ||
| </Stack> | ||
|
|
There was a problem hiding this comment.
I have limited knowledge of this app (first time actually looking at this code) but this looks good to me. I do want to note that this component is getting lorrrge and is probably a good candidate for a refactor in the future--we could definitely abstract some of those API calls, especially if they're used in other components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
1. Targeted Issue
(The first step to a good solution is knowing the problem. Please link the issue here.)
Issue #... or
Ticket #...
https://trello.com/c/v1vEtFrr/140-add-team-number-to-the-mentors-profile
2. Overview of Solution
(You've put in the hard work, now's your chance to tell us about it. What's your solution in a nutshell?)
ProfileMentor.js now has a teamNumber state, which is displayed above the ProfileBasicInfo.
In EditProfile.js, the mentorinfo axios call now handles the teamNumber data, and the teamNumber form field is no longer tied to the isMentee state. Also, the useEffect hook and editProfile function now use async-await to handle promises.
3. Tools Used
(Share the tools, libraries, or techniques you've used in your solution.)
Promises in EditProfile.js now use async-await. The editProfile function bundles the 2 patch requests into a single Promise using Promise.all(), allowing them to be run concurrently.
4. Testing Strategy
(No code is complete without tests. Outline what you've tested and how.)
Testing hasn't been implemented on the frontend yet (plus I don't really know how to test React code). Locally run the front and back ends, and edit a part of a mentor's profile.
5. Future Implications
(Let's anticipate potential effects of your changes. Are there any potential issues down the line?)
If any future contributor is not used to using async await, this will hopefully serve as a nice example.
6. Screenshots
(A picture is worth a thousand words. Include screenshots of your changes if relevant.)
7. Code Reviewers
(Who else is in the loop? Mention your team or other contributors here.)
@emilyflo @GitLukeW @nzeager
Before you go...
Big high-fives for your incredible pull request! We're thrilled to have you as a contributor! Our team will dig into your proposed changes and give you some feedback or merge them if they're good to go. Your contributions mean the world to us!