-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download section & new installation FAQs #163
Conversation
Yup I will. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@B0pol I didn't like the shadow, too. I needed to add it because of the position of the arrows. What about that: |
675f978
to
37b289c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a look at the content changes, but couldn't read into the code. I guess it should be alright.
337819a
to
f17dfe8
Compare
It is now possible to reference an FAQ entry in the URL like: |
Wow I was looking for this exactly yesterday… IMO we should add a link icon at the right of the question E.g. (Icon made by Freepik from www.flaticon.com) (just an example, we should make it red) |
good idea. I was also thinking about changing the window location / URL when a FAQ entry is clicked so one can link easier. Adding an icon is even better |
cc8efa1
to
124096a
Compare
ecfbfac
to
ab3fce7
Compare
Use data-newpipe-api attribute instead of class name to register for web-API data. Add data-newpipe-api-attribute attribute to specify that an attribute and not the inner HTML of the element should be updated.
to the head of the document. To do so, add extraJS to the YAML font-matter of a site or layout with the name(s) of the script(s).
The specified FAQ entry will be expanded and the window scrolls to it automatically. Add an anchor icon on the right side of the FAQ and tutorial tiles to copy the URL directly. Clicking on the anchor copies either the URL to the tutorial page or the URL of the current page referencing the FAQ entry.
ab3fce7
to
15fc6b3
Compare
I updated the release data to match version 0.19.8 and improved the documentation. |
Add new FAQ category: "install"
15fc6b3
to
c6c683c
Compare
Added a new download section, did some small refactoring of bad code (more info in the commits) and added the NewPipe legacy icon to the press kit.
I have also added (but commented out for now) a "get started" section with some links to some FAQs and tutorials. The plan is to enable it once we have more tutorials. I'd like to add some icons / graphics to it. This is how it looks:
I also thought about removing all borders from both ("get it" and "get started") grids and add some margin to all boxes. I could not decide, which version looks better.
I'd like to get some feedback on one the way, the link to the release post and the latest changelog are stored / processed. See the
_includes/release_data.html
. We have three options to store the data:_data/release.yml
: We cannot use liquid tags to generate the URL to the blog post and would need to escape every>
in the HTML of the changelog_includes/release_data.html
as done now.When there is a blog post for the current release, there is also a "blog post" button in the "Release Highlights" section.
To Do
@Poolitzer @gkeegan Can you take care of the tutorials, please?
Should be merged with #159