Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download section & new installation FAQs #163

Merged
merged 9 commits into from
Aug 12, 2020
Merged

Download section & new installation FAQs #163

merged 9 commits into from
Aug 12, 2020

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Jun 20, 2020

Added a new download section, did some small refactoring of bad code (more info in the commits) and added the NewPipe legacy icon to the press kit.

image

image

I have also added (but commented out for now) a "get started" section with some links to some FAQs and tutorials. The plan is to enable it once we have more tutorials. I'd like to add some icons / graphics to it. This is how it looks:
image

I also thought about removing all borders from both ("get it" and "get started") grids and add some margin to all boxes. I could not decide, which version looks better.

I'd like to get some feedback on one the way, the link to the release post and the latest changelog are stored / processed. See the _includes/release_data.html. We have three options to store the data:

  1. Store in _data/release.yml: We cannot use liquid tags to generate the URL to the blog post and would need to escape every > in the HTML of the changelog
  2. Store data in _includes/release_data.html as done now.
  3. Store data in web-api: this allows us to display some info in the app, too.

When there is a blog post for the current release, there is also a "blog post" button in the "Release Highlights" section.

To Do

  • Add tutorial for adding our F-Droid repo
  • Add tutorial for installing NewPipe
  • Replace link placeholders to the tutorials mentioned above
  • Code clean up

@Poolitzer @gkeegan Can you take care of the tutorials, please?

Should be merged with #159

@TobiGr TobiGr force-pushed the download-section branch from cdc8d00 to cca399a Compare June 20, 2020 17:11
@Poolitzer
Copy link
Member

Yup I will.

Copy link
Member

@B0pol B0pol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small review

I don't think that a big shadow is a good idea. Just look at when you hover it:

Link is not really visible, and QRcode too, which makes it impossible to flash the code for me

Also, don't forget to update "Last updated: month year" on every files you modified.

press/index.html Outdated Show resolved Hide resolved
press/index.html Show resolved Hide resolved
@TobiGr TobiGr force-pushed the download-section branch from cca399a to fb46744 Compare June 20, 2020 17:59
@TobiGr
Copy link
Contributor Author

TobiGr commented Jun 20, 2020

@B0pol I didn't like the shadow, too. I needed to add it because of the position of the arrows. What about that:
image

@TobiGr TobiGr force-pushed the download-section branch 2 times, most recently from 675f978 to 37b289c Compare June 20, 2020 21:59
Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a look at the content changes, but couldn't read into the code. I guess it should be alright.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@TobiGr TobiGr force-pushed the download-section branch 3 times, most recently from 337819a to f17dfe8 Compare June 27, 2020 17:04
@TobiGr
Copy link
Contributor Author

TobiGr commented Jun 27, 2020

It is now possible to reference an FAQ entry in the URL like: https://newpipe.schabi.org/FAQ/#download-signing-keys
There is now a tutorial for adding our F-Droid repo. Thank you @gkeegan!

@B0pol
Copy link
Member

B0pol commented Jun 27, 2020

It is now possible to reference an FAQ entry in the URL like: https://newpipe.schabi.org/FAQ/#download-signing-keys

Wow I was looking for this exactly yesterday… IMO we should add a link icon at the right of the question

E.g. (Icon made by Freepik from www.flaticon.com) (just an example, we should make it red)

@TobiGr
Copy link
Contributor Author

TobiGr commented Jun 27, 2020

IMO we should add a link icon at the right of the question

good idea. I was also thinking about changing the window location / URL when a FAQ entry is clicked so one can link easier. Adding an icon is even better

@TobiGr TobiGr force-pushed the download-section branch 2 times, most recently from cc8efa1 to 124096a Compare June 27, 2020 22:06
@TobiGr TobiGr changed the title Download section Download section & new installation FAQs Jun 28, 2020
@TobiGr TobiGr force-pushed the download-section branch from 124096a to 39c9b0f Compare July 2, 2020 17:24
@TobiGr TobiGr force-pushed the download-section branch from 39c9b0f to dd09271 Compare July 28, 2020 21:42
@TobiGr TobiGr force-pushed the download-section branch from dd09271 to ecfbfac Compare July 30, 2020 11:15
TobiGr added 4 commits August 13, 2020 01:40
Use data-newpipe-api attribute instead of class name to register for web-API data.
Add data-newpipe-api-attribute attribute to specify that an attribute and not the inner HTML of the element should be updated.
to the head of the document.
To do so, add extraJS to the YAML font-matter of a site or layout with the name(s) of the script(s).
The specified FAQ entry will be expanded and the window scrolls to it automatically.
Add an anchor icon on the right side of the FAQ and tutorial tiles to copy the URL directly. Clicking on the anchor copies either the URL to the tutorial page or the URL of the current page referencing the FAQ entry.
@TobiGr
Copy link
Contributor Author

TobiGr commented Aug 12, 2020

I updated the release data to match version 0.19.8 and improved the documentation.

@TobiGr TobiGr merged commit 5da82a9 into master Aug 12, 2020
@TobiGr TobiGr deleted the download-section branch August 12, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants