Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use String.isBlank(). #992

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

Isira-Seneviratne
Copy link
Member


Use String's isBlank() method, introduced in Java 11.

@TobiGr TobiGr merged commit 41c8dce into TeamNewPipe:dev Nov 30, 2022
@AudricV
Copy link
Member

AudricV commented Dec 24, 2022

I think we merged this PR too fast... This method doesn't exist on Android until API 33 and is not available with desugarging!

@Isira-Seneviratne
Copy link
Member Author

I think we merged this PR too fast... This method doesn't exist on Android until API 33 and is not available with desugarging!

I checked it on my end first, and the method gets desugared.

@AudricV
Copy link
Member

AudricV commented Dec 25, 2022

I didn't find anything about desugarging of this method. Do you have any source?

@Isira-Seneviratne
Copy link
Member Author

Isira-Seneviratne commented Dec 25, 2022

I didn't find anything about desugarging of this method. Do you have any source?

I built and decompiled the app, and there was a backport class for the method.

@Isira-Seneviratne Isira-Seneviratne deleted the String_isBlank branch January 1, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants