[YouTube] Add support to extract total comment count #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FireMasterK
force-pushed
the
comments-count
branch
from
19b3eb8 to
04394ee
Compare
litetex
reviewed
Feb 8, 2022
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Outdated
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Outdated
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Show resolved
Hide resolved
FireMasterK
force-pushed
the
comments-count
branch
2 times, most recently
from
0616b5d to
ad8659b
Compare
litetex
reviewed
Feb 10, 2022
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Outdated
Show resolved
Hide resolved
FireMasterK
force-pushed
the
comments-count
branch
from
ad8659b to
0779c33
Compare
|
Any progress? |
|
@FireMasterK any update? |
|
I'm currently a bit busy, I may be able to resume work on this the next or the week after. |
|
Closing in favor of #936 |
|
This PR is about implementing replies count of a comment, while yours is about a different feature, the comments count of a stream! Reopening. |
34 tasks
FireMasterK
force-pushed
the
comments-count
branch
from
0779c33 to
d158f51
Compare
AudricV
requested changes
Dec 8, 2022
extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfo.java
Outdated
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsExtractor.java
Outdated
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Show resolved
Hide resolved
...rc/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeCommentsExtractorTest.java
Outdated
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfo.java
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfo.java
Show resolved
Hide resolved
Stypox
requested changes
Dec 31, 2022
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Outdated
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Show resolved
Hide resolved
FireMasterK
force-pushed
the
comments-count
branch
from
db241e7 to
22a47da
Compare
Stypox
approved these changes
Jan 11, 2023
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #793