Add Bandcamp comments (first page) #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fynngodau
added
enhancement
TobiGr
approved these changes
May 1, 2021
TobiGr
reviewed
May 1, 2021
.../test/java/org/schabi/newpipe/extractor/services/bandcamp/BandcampCommentsExtractorTest.java
Outdated
Show resolved
Hide resolved
This was referenced May 2, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #586.
This PR only parses the first set of comments (max. 3), because for those we can parse the website while we need to use some sort of API for additional pages (which the JS on the website usually calls). I might open an additional PR in the future that adds the capability of loading additional pages.
(Here would be an album where you can click "more" to load more comments: https://alfamist.bandcamp.com/album/bring-backs)
Demo (https://c418.bandcamp.com/track/wet-hands):