Add AccountTerminatedException for terminated channels #580
Conversation
TobiGr
added
bug
TobiGr
force-pushed
the
accountTerminated
branch
3 times, most recently
from
3abbdea to
f1a1591
Compare
|
I could not find more info on deleted and terminated channels in the docs of the other services. |
...src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelExtractorTest.java
Outdated
Show resolved
Hide resolved
| assertEquals(e.getMessage(), | ||
| "This account has been terminated for a violation of YouTube's Terms of Service."); |
There was a problem hiding this comment.
I would remove the assertions for the error message. They are bound to fail very soon, if they change the wording. Only usecase i can think of for them, is directly displaying them to the end-user in which case, the exact wording does not change the correctness of the implementation.
| if (alertText != null && alertText.contains("This account has been terminated")) { | ||
| if (alertText.contains("violation") || alertText.contains("violating") | ||
| || alertText.contains("infringement")) { |
There was a problem hiding this comment.
what happens if the localization is changed to non-english. I would assume the error messages are localized
There was a problem hiding this comment.
@XiangRongLin Yes, they are, it's the same thing for the error messages from YouTube videos.
I think in the future we need to implement something which stores strings of the error messages for each localization and compare with the value provided by YouTube in the language used for the extraction of YouTube datas.
|
Oh wait, this has to be addressed: |
Adds a new
ContentNotAvailableException:AccountTerminatedExceptionto distinguish between terminated channels. The fieldreasonprovides more info on why the account has been terminated. This fixes a NPE when getting the feed for a terminated channel in YouTubeFeedExtractor.addCLOSED_BY_OWNERreason (I need a dedicated channel for thisimplement in other services