Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[media.ccc.de] Fix NPE in search results if they contain a future talk #505

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Dec 30, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

If the release_date is null, the talk is going to be held in the future. Thus the result's StreamInfo will empty video and audio stream lists. For this reason, do not include future talks in the search results.

Fixes TeamNewPipe/NewPipe#5306

@TobiGr TobiGr added bug Issue is related to a bug media.ccc.de service, https://media.ccc.de labels Dec 30, 2020
@TobiGr TobiGr force-pushed the meida.ccc.de_search_fix branch from ddf88b1 to edf8dd0 Compare December 30, 2020 17:34
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@TobiGr TobiGr force-pushed the meida.ccc.de_search_fix branch from d12ccb7 to 2cbc3cc Compare December 31, 2020 16:03
@Stypox Stypox merged commit 7c774c8 into dev Jan 15, 2021
@TobiGr TobiGr deleted the meida.ccc.de_search_fix branch January 15, 2021 13:18
@TobiGr TobiGr mentioned this pull request Jan 18, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug media.ccc.de service, https://media.ccc.de
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException at search on media.ccc.de
2 participants