-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract stream segments for YouTube #479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
Nice! Maybe there is a way to integrate this into the background player as well. |
34642c2
to
9a7a224
Compare
I've updated the commits by using I'll update the test apk shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. That looks better now!
This PR extracts the stream segments data provided by YouTube and makes them accessible inside
StreamInfo
. Other services which don't support this data return an empty list when trying getting them. This also applies to streams in YouTube which aren't divided by the uploader.The added data class
StreamSegment
contains the following data:String title
: Title of the chapter set by the uploaderint startTimeSeconds
: Starting point of the chapter in secondsString url
: Direct link to the segment (...?t=
)String previewUrl
: Url to the image at the start positionTest against NewPipe
Demo video in NewPipe's player: https://streamable.com/e/3e27wa
Debug app: app-debug-segments-20201212.zip