Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create FileUtils #450

Merged
merged 1 commit into from
Nov 1, 2020
Merged

create FileUtils #450

merged 1 commit into from
Nov 1, 2020

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Nov 1, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Util class to write file to disk
Can be used to debug and test, for example writing a service's JSON response
(especially useful if the response provided by the service is not documented)

@B0pol B0pol added the enhancement New feature or request label Nov 1, 2020
Stypox
Stypox requested changes Nov 1, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this file should only be used by tests, I think you should put it under src/test/java/.... Other than that, if you tested the methods a little bit, I guess this can be merged without further thinking, as it is only a utility class for testing

@B0pol
Copy link
Member Author

B0pol commented Nov 1, 2020

I moved the file

@B0pol B0pol requested a review from Stypox November 1, 2020 16:15
@Stypox Stypox merged commit 2f02c0e into TeamNewPipe:dev Nov 1, 2020
@B0pol B0pol deleted the fileutils branch November 1, 2020 18:29
This was referenced Nov 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B0pol @Stypox