Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Objects methods. #419

Merged
merged 3 commits into from
Dec 12, 2020
Merged

Use Objects methods. #419

merged 3 commits into from
Dec 12, 2020

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Oct 19, 2020 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Note: The Objects method calls are desugared when the minSdkVersion is below 19 and Java 8 support is enabled, so the changes are compatible with NewPipe Legacy:

Screenshot 2020-10-19 183047

@Isira-Seneviratne Isira-Seneviratne mentioned this pull request Oct 19, 2020
Closed
5 tasks
@wb9688
Copy link
Contributor

wb9688 commented Oct 19, 2020

Note: The Objects method calls are desugared when the minSdkVersion is below 19, so the changes are compatible with NewPipe Legacy.

Only with core library desugaring, right?

@Isira-Seneviratne
Copy link
Member Author

Isira-Seneviratne commented Oct 19, 2020 •
edited
Loading

Note: The Objects method calls are desugared when the minSdkVersion is below 19, so the changes are compatible with NewPipe Legacy.

Only with core library desugaring, right?

No, I found that it just needs Java 8 support enabled.

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Objects_methods branch 6 times, most recently from 810aeca to fd8e01e Compare November 4, 2020 00:19
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Objects_methods branch 2 times, most recently from 9797125 to dd9076f Compare November 8, 2020 02:08
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Objects_methods branch 2 times, most recently from a331bfb to bec6981 Compare November 26, 2020 00:39
Stypox
Stypox approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-D

@Stypox Stypox merged commit 2b622fd into TeamNewPipe:dev Dec 12, 2020
@Isira-Seneviratne Isira-Seneviratne deleted the Use_Objects_methods branch December 14, 2020 03:21
This was referenced Dec 22, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isira-Seneviratne @wb9688 @Stypox