Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing new ytInitialData #415

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix parsing new ytInitialData #415

merged 1 commit into from
Oct 16, 2020

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Oct 16, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Fixes TeamNewPipe/NewPipe#4201

@wb9688 wb9688 added bug Issue is related to a bug youtube service, https://www.youtube.com/ labels Oct 16, 2020
Stypox
Stypox previously approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex looks good (I was about to push a PR, too ;-) )

@TobiGr TobiGr changed the base branch from dev to master October 16, 2020 18:59
@TobiGr TobiGr dismissed Stypox’s stale review October 16, 2020 18:59

The base branch was changed.

@opusforlife2
Copy link
Collaborator

opusforlife2 commented Oct 16, 2020 •
edited
Loading

Test APK. (づ｡◕‿‿◕｡)づ

Edit: Oh. It's linked in the issue. Never mind.

Edit 2: Still would be good to add it to the OP.

@opusforlife2
Copy link
Collaborator

The base branch was changed.

Hotfix, @TobiGr?

@wb9688
Copy link
Contributor Author

wb9688 commented Oct 16, 2020

Why even? There are only bug fixes in dev: v0.20.0...dev

@TobiGr TobiGr changed the base branch from master to dev October 16, 2020 19:57
@TobiGr TobiGr merged commit f82eda9 into TeamNewPipe:dev Oct 16, 2020
@FireMasterK FireMasterK mentioned this pull request Oct 20, 2020
Closed
@afuous afuous mentioned this pull request Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

@Stypox Stypox Stypox left review comments

Assignees
No one assigned
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

newpipe can't load any youtube link and show no result for any search
4 participants
@wb9688 @opusforlife2 @TobiGr @Stypox