Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SoundCloud test artist account name #413

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

Scrxtchy
Copy link
Contributor

@Scrxtchy Scrxtchy commented Oct 16, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

The account used to run tests on no longer has their account name as specified in the testing suite.
image

There are a few other tests that fail on my system, but I believe this to be a problem with the testing utilities, as my system locale is set to Japanese
image

Ideally, these should be run on controlled accounts run by maintainers. This is something I am not putting my name forward for. In the meantime this is a simple solution

@TobiGr TobiGr added the soundcloud service, https://soundcloud.com/ label Oct 16, 2020
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@TobiGr TobiGr merged commit 9a785f9 into TeamNewPipe:dev Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soundcloud service, https://soundcloud.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants