-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not list YouTube's OTF streams #400
Conversation
Does this remove the streams causing infinite loading? |
@Stypox: Yes, that's what this PR is for. |
@TobiGr I'd merge this in 0.20.0 to bring better stability, it is such a small change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should add a test for this? Maybe we can do without, if you tested well, since this code is going to be removed anyway in the future
Stuff like this should be done in the frontend and not the extractor. We can merge this now, but IMO we should extract all itags and provide all stream formats through the extractor. The frontend needs to sort out unsupported formats. |
@TobiGr: No. Currently NPE is supposed to only return progressive HTTP streams (and sometimes a torrent as well). These streams aren't progressive HTTP, so NPE shouldn't return them. There is also not really a proper way how NP could figure that out. With my DASH/HLS support PR, there will be a way to specify what kind of streaming method should be used, and then a frontend should skip e.g. DASH streams if they don't support that. However that's not the case yet. After I finish that PR and that gets merged, I'll make a PR extracting all itags based on the metadata that YouTube provides, which could include e.g. 360° videos, which should then also be filtered out by frontends not supporting that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore streams that are delivered using YouTube's OTF format, as those only work with DASH and not with progressive HTTP.