[SoundCloud] Fix concurrency issue when getting the client id #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciocolli
added
bug
|
Thanks a lot for fixing this! Why does this not happen with YouTube or YouTube Music though? PS: I didn't take a look at the relevant code yet, but I definitely will tomorrow hopefully. |
wb9688
approved these changes
Jun 27, 2020
This was referenced Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client id method didn't work properly when the hardcoded key was no longer valid, an easy example would be when playing a playlist that pre-loaded more than 1 item.
Simply making the method
synchronizedshould solve this problem.