Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display parent channel details #313

Merged
merged 3 commits into from
May 8, 2020
Merged

Display parent channel details #313

merged 3 commits into from
May 8, 2020

Conversation

Royosef
Copy link
Contributor

@Royosef Royosef commented Apr 13, 2020

Add parent channel info to ChannelExtractor, StreamExtractor: name, url & avatar url

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@Royosef Royosef mentioned this pull request Apr 13, 2020
Merged
5 tasks
wb9688
wb9688 requested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@wb9688 wb9688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also still change the tests for PeerTube streams.

extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamExtractor.java Outdated Show resolved Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamExtractor.java Outdated Show resolved Hide resolved
wb9688
wb9688 approved these changes Apr 19, 2020
View reviewed changes
Copy link
Contributor

@wb9688 wb9688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good now. You have to rebase on dev though.

@Royosef Royosef force-pushed the DisplayParentChannelDetails branch from 9391baa to fc3968f Compare April 19, 2020 20:09
@wb9688 wb9688 added this to the 0.19.4 milestone Apr 19, 2020
@B0pol B0pol added the enhancement New feature or request label Apr 20, 2020
wb9688
wb9688 reviewed May 4, 2020
View reviewed changes
extractor/build.gradle Outdated Show resolved Hide resolved
@wb9688 wb9688 force-pushed the DisplayParentChannelDetails branch from fc3968f to a408661 Compare May 7, 2020 18:22
@wb9688
Copy link
Contributor

wb9688 commented May 7, 2020

I rebased and removed the unrelated extractor/build.gradle change.

@wb9688 wb9688 merged commit 44d382b into TeamNewPipe:dev May 8, 2020
This was referenced May 29, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wb9688 wb9688 wb9688 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.19.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Royosef @wb9688 @B0pol