Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Android versions earlier than KitKat #269

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Fix for Android versions earlier than KitKat #269

merged 1 commit into from
Mar 1, 2020

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Mar 1, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I did test the API against NewPipe.
  • I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.

The StandardCharsets class was only introduced in KitKat, so this is only relevant for NewPipe Legacy.

TobiGr
TobiGr approved these changes Mar 1, 2020
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why support of old versions is a pain...
We are using StandardCharsets several times in the downloader as well. We might want to open an issue about that in the legacy repo to warn them about potential crashes.

@TobiGr TobiGr merged commit fcbc96a into TeamNewPipe:dev Mar 1, 2020
@wb9688
Copy link
Contributor Author

wb9688 commented Mar 1, 2020

@TobiGr: Yup… I don't think you need to open an issue there, as Android Studio would just say those classes don't exist.

@TobiGr TobiGr mentioned this pull request Jan 27, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wb9688 @TobiGr