[YouTube] Fix serialization of Videos channel tab when it is already fetched #1222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the ability to serialize
ReadyChannelTabListLinkHandler
s for YouTube channels. It was due to the usage of thechannelHeader
field ofYoutubeChannelExtractor
, as explained in TeamNewPipe/NewPipe#11356 (comment). Even if this usage has been removed by copying the instance members into a new object, theChannelHeader
class ofYoutubeChannelHelper
was not serializable, so crashes would still happen if I didn't make this class serializable.Optional
as fields and parameters of methods have been removed in the related extractor code as it is not a good practice. This simplifies in some places channel info extraction code.This PR and the issue it fixes also raise the question of the limits of the serialization system we use, both in the app and in the extractor.
Debug NewPipe APK based on app commit
035c394cf6704c0af9077c01ebfa55b810d02140
with changes from commit 422df70: app-debug.zipFixes TeamNewPipe/NewPipe#11356.